On Wed, Apr 08, 2015 at 10:29:03PM -0400, Hans-Peter Nilsson wrote:
> On Wed, 8 Apr 2015, Segher Boessenkool wrote:
> > 2015-04-08 Segher Boessenkool <seg...@kernel.crashing.org>
> >
> > * combine.c (is_parallel_of_n_reg_sets): Change first argument
> > from an rtx_insn * to an rtx.
> > (try_combine): Adjust both callers. Use it once more.
Hi,
> That "once more" is outside of #ifndef HAVE_cc0 and
> is_parallel_of_n_reg_sets is only defined inside of one. Boom.
Oops. So sorry.
> Full test on a cc0 target (such as cris-elf) is advised, and at
> least "make all-gcc" would be a minimum after fixing.
I tested a cross to cris-linux and built a Linux kernel with the trivial
patch (attached); doing that for all other cross configs is in progress.
It would be nice if there would be some cc0 target in the compile farm,
since cc0 isn't going away any time soon :-(
Okay if testing has finished successfully?
Segher
2015-04-09 Segher Boessenkool <seg...@kernel.crashing.org>
PR rtl-optimization/65693
* combine.c (is_parallel_of_n_reg_sets): Move outside of
#ifndef HAVE_cc0.
---
gcc/combine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/combine.c b/gcc/combine.c
index 32950383..0836f74 100644
--- a/gcc/combine.c
+++ b/gcc/combine.c
@@ -2492,7 +2492,6 @@ update_cfg_for_uncondjump (rtx_insn *insn)
}
}
-#ifndef HAVE_cc0
/* Return whether PAT is a PARALLEL of exactly N register SETs followed
by an arbitrary number of CLOBBERs. */
static bool
@@ -2517,6 +2516,7 @@ is_parallel_of_n_reg_sets (rtx pat, int n)
return true;
}
+#ifndef HAVE_cc0
/* Return whether INSN, a PARALLEL of N register SETs (and maybe some
CLOBBERs), can be split into individual SETs in that order, without
changing semantics. */
--
1.8.1.4
