At Fri, 17 Apr 2015 10:53:51 -0600, Jeff Law wrote: > > On 03/05/2015 09:50 AM, Yoshinori Sato wrote: > > Add h8300-*-linux target for h8300 linux kernel and userland. > > > > h8300-*-elf is some difference of standard elf. > > h8300-*-linux is compatible of standard elf rules. > > > > Thanks. > > > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > > index cfacea1..fc5101c 100644 > > --- a/gcc/ChangeLog > > +++ b/gcc/ChangeLog > > @@ -1,3 +1,12 @@ > > +2015-03-06 Yoshinori Sato <ys...@users.sourceforge.jp> > > + > > + * config.gcc: Add h8300-*-linux > > + * config/h8300/h8300.c (h8300_option_override): > > + Exclusive -mh vs -ms/-msx > > + (h8300_file_start): Target priority -msx > -ms > -mh > > + * config/h8300/linux.h: New file. > > + * config/h8300/t-linux: Likewise. > Mostly OK. Two minor issues/questions that need to be addressed, then > this ought to be able to be committed to the trunk. >
OK. > > > > > + if (TARGET_H8300H && (TARGET_H8300S || TARGET_H8300SX)) > > + { > > + target_flags ^= MASK_H8300H; > > + } > I'm a bit concerned by this. Why did you need to make this change? > The flag is exclusion, but it's set both. > > > +#undef LINK_SPEC > > +#define LINK_SPEC "%{mh:%{!mn:-m h8300helf_linux}} %{ms:%{!mn:-m > > h8300self_linux}}" > Presumably you don't need to support normal mode or the older H8/300 > processor. Does that allow you to simplify LINK_SPEC at all? OK. I will cleanup. > I'm going to assume the sfp-machine.h contents are correct. > > You did file a copyright form with the FSF, right (I believe I asked > before, but I don't recall the result). Yes. gnu.org #976270 > Jeff -- Yoshinori Sato <ys...@users.sourceforge.jp>