On 16 March 2012 at 11:04, Bernhard Reutner-Fischer <rep.dot....@gmail.com> wrote: > On Thu, Mar 15, 2012 at 08:35:47PM +0100, Jakub Jelinek wrote: >>On Thu, Mar 15, 2012 at 05:56:32PM +0100, Bernhard Reutner-Fischer wrote: >>> On Thu, Mar 15, 2012 at 04:57:12PM +0100, Richard Guenther wrote: >>> >On Thu, Mar 15, 2012 at 1:39 PM, Bernhard Reutner-Fischer >>> ><rep.dot....@gmail.com> wrote:
>>Even with that file in, libgomp and libitm make check still fail, >>can't find fortran-modules.exp. > > I have committed the attached as r185460. > > The underlying problem is that dejagnu's runtest.exp only allows for a > single "libdir" where it searches for includes -- see comment in > libgomp.exp and libitm.exp > > While just adding more and more load_gcc_lib calls to users outside of > gcc/ is the easy way out, it is (IMHO) error prone (i ran make check > just in gcc and not in toplevel, fixed my script now). > > It would be desirable if dejagnu would just find all the currently > load_gcc_lib'ed files on its own, via load_lib. > One could > - teach dejagnu to treat libdir as a list of paths I've done the above some time ago, dejagnu >= 1.5.2 has a "libdirs" variable so i'd like to propose to: - Bump the required dejagnu version for gcc-6 to (let's say) 1.5.3 - Afterwards apply the GCC part of https://gcc.gnu.org/ml/gcc-patches/2012-03/msg01169.html in essence wiping all load_gcc_lib workarounds from libgomp and libitm. Oh, and it was copied to literally all toplevel libraries by now, it seems, so could be deleted there too. What do you think? PS: I see that gcc-dg.exp still has this bug: +# BUG: gcc-dg calls gcc-set-multilib-library-path but does not load gcc-defs! thanks,
