Hi Kugan, On 25/04/15 00:30, Kugan wrote:
Thanks for the review. I have updated the patch based on the comments with some other minor changes. Bootstrapped and regression tested on aarch64-none-linux-gnu with no-new regressions. Is this OK for trunk?Thanks, Kugan gcc/ChangeLog: 2015-04-24 Kugan Vivekanandarajah <kug...@linaro.org> Jim Wilson <jim.wil...@linaro.org> * config/arm/aarch-common-protos.h (struct mem_cost_table): Added new fields loadv and storev. * config/aarch64/aarch64-cost-tables.h (thunderx_extra_costs): Initialize loadv and storev. * config/arm/aarch-cost-tables.h (generic_extra_costs): Likewise. (cortexa53_extra_costs): Likewise. (cortexa57_extra_costs): Likewise. (xgene1_extra_costs): Likewise. * config/aarch64/aarch64.c (aarch64_rtx_costs): Update vector rtx_costs.Due to the struct mem_cost_table update for aarch64, arm cost tables also need to be updated. Please find the patch that does this. Regression tested on arm-none-linux-gnu with no-new regressions. Is this OK for trunk? Thanks, Kugan gcc/ChangeLog: 2015-04-25 Kugan Vivekanandarajah <kug...@linaro.org> * config/arm/arm.c (cortexa9_extra_costs): Initialize loadv and storev. (cortexa8_extra_costs): Likewise. (cortexa5_extra_costs): Likewise. (cortexa7_extra_costs): Likewise. (cortexa12_extra_costs): Likewise. (cortexa15_extra_costs): Likewise. (v7m_extra_costs): Likewise.
This arm part looks ok to me FWIW (if the approach in the aarch64 patch is deemed ok by the aarch64 maintainers), it just syncs the fields of the common cost struct between arm and aarch64. Please only commit this if the aarch64 patch gets approved and committed at the same time, otherwise we'll get a build failure. Having a look at the arm rtx costs and seeing if we can improve them in the same way as the aarch64 ones would be good as a follow up at some point too. Thanks, Kyrill
