On Fri, May 8, 2015 at 9:16 PM, Tom de Vries <tom_devr...@mentor.com> wrote: > On 08-05-15 17:31, Richard Biener wrote: >>> >>> >OK for trunk? >> >> As noted in one of the PRs I think that it is the proper time to >> re-implement the stdarg optimization on the un-lowered form which >> should also fix this. > > > AFAIU, the implementation of the stdarg optimization on the un-lowered form > should contain an independent fix for this problem, and this fix won't be > functional any more then, so indeed, it's a patch with (hopefully) a limited > lifespan. > > But I thought that the patch is simple and low-risk enough to accept for > trunk now, hence the submission. > > Also, I suppose it's not bad to start developing from a situation where more > tests are passing.
Sure - but this adds a pass over the IL plus an SSA update to the compile. Sth which may also enable va-unrelated optimization and thus may cause regressions if you remove it later... Otherwise I agree of course. Thanks, Richard. > Thanks, > - Tom
