On Tue, May 19, 2015 at 8:33 AM, <paul_kon...@dell.com> wrote: > > ________________________________________ > From: gcc-patches-ow...@gcc.gnu.org [gcc-patches-ow...@gcc.gnu.org] on behalf > of H.J. Lu [hjl.to...@gmail.com] > Sent: Tuesday, May 19, 2015 11:27 AM > To: Joseph Myers > Cc: Magnus Granberg; GCC Patches > Subject: Re: PING^3: [PATCH]: New configure options that make the compiler > use -fPIE and -pie as default option > > On Tue, May 19, 2015 at 8:21 AM, Joseph Myers <jos...@codesourcery.com> wrote: >> ... >> I think the whole thing should be posted as one patch, with both the >> target-independent changes and the target-specific changes for all >> targets. >> > > That is what makes me concerned. I have some simple target-specified > patches which weren't reviewed for years. What will happen if no one > reviews some simple target-specified changes due to > > 1. Reviewers don't have access to those targets. > 2. Target maintainers aren't review them. > 3. There are no clear maintainers for those targets. > > As the result, my patch may go nowhere. > --- > > But that hasn't stopped others from posting patches like that, or getting > them approved. And we also have global maintainers who can approve things. > It feels a bit like a hypothetical issue is being used as a reason to do part > of the job.
It is not hypothetical. See: https://gcc.gnu.org/ml/gcc-patches/2012-09/msg01558.html It happened before. I don't want to make it harder for global maintainers to review a patch which has zero-impact on a target if --enable-default-pie isn't used. -- H.J.