On 06/01/2015 04:08 PM, Martin Liška wrote: > On 06/01/2015 02:18 PM, Richard Biener wrote: >> On Mon, Jun 1, 2015 at 1:38 PM, Martin Liška <mli...@suse.cz> wrote: >>> On 05/29/2015 06:09 PM, Vidya Praveen wrote: >>>> >>>> Martin, >>>> >>>> The following change: >>>> >>>> @@ -2655,10 +2655,10 @@ s-iov: build/gcov-iov$(build_exeext) $(BASEVER) >>>> $(DEVPHASE) >>>> >>>> GCOV_OBJS = gcov.o >>>> gcov$(exeext): $(GCOV_OBJS) $(LIBDEPS) >>>> - +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) $(LIBS) -o $@ >>>> + +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) >>>> build/hash-table.o ggc-none.o $(LIBS) -o $@ >>>> >>>> >>>> seem to cause canadian cross build failure for arm and aarch64 on x86_64 as >>>> build/hash-table.o and ggc-none.o are not built by the same compiler? >>>> >>>> arm-none-linux-gnueabi-g++ -no-pie -g -O2 -DIN_GCC -fno-exceptions >>>> -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing >>>> +-Wwrite-strings -Wcast-qual -Wmissing-format-attribute >>>> -Woverloaded-virtual -pedantic -Wno-long-long -Wn >>>> build/hash-table.o ggc-none.o libcommon.a >>>> ../libcpp/libcpp.a ../libbacktrace/.libs/libbacktrace.a >>>> ../libiberty/libiberty.a .. >>>> +/libdecnumber/libdecnumber.a -o gcov >>>> build/hash-table.o: file not recognized: File format not recognized >>>> collect2: error: ld returned 1 exit status >>>> make[1]: *** [gcov] Error 1 >>>> >>>> >>>> Should it be: >>>> >>>> - +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) $(LIBS) -o $@ >>>> + +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) hash-table.o >>>> ggc-none.o $(LIBS) -o $@ >>>> >>>> instead? >>> >>> Hello Vidya. >>> >>> Thanks for pointing out. To be honest, I'm not a build system guru and it's >>> hard for me to verify >>> that the change you suggest is the correct. >>> >>> May I please ask you for sending a patch to mailing? >> >> gcov isn't a build but a host tool so the patch looks good to me. >> >> Richard. >> >>> Thanks, >>> Martin >>> >>>> >>>> VP. >>>> >>>> >>>> On 15/05/15 15:38, Martin Liška wrote: >>>>> Hello. >>>>> >>>>> Following patch attempts to rewrite memory reports for GCC's internal >>>>> allocations >>>>> so that it uses a new template type. The type shares parts which are >>>>> currently duplicated, >>>>> adds support for special 'counters' and introduces new support for >>>>> hash-{set,map,table}. >>>>> >>>>> Transformation of the current code is a bit tricky as we internally used >>>>> hash-table as main >>>>> data structure which takes care of location-related allocations. As I >>>>> want to add support even >>>>> for hash tables (and all derived types), header files inclusion and >>>>> forward declaration is utilized. >>>>> >>>>> Feel free to comment the patch, as well as missing features one may want >>>>> to track by location sensitive >>>>> memory allocation. >>>>> >>>>> Attachment contains sample output taken from tramp3d-v4.cpp. >>>>> >>>>> Thanks, >>>>> Martin >>>>> >>>> >>> > > Ok. > > I'm going to install following patch. > > Thanks, > Martin >
Hi. Vidya notified me that I used a wrong email for his Changelog entry. This is patch I'm going to install. Thanks, Martin
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index daf6476..63e69d2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,4 +1,4 @@ -2015-06-01 Vidya Praveen <vidya.prav...@atmel.com> +2015-06-01 Vidya Praveen <vidyaprav...@arm.com> * Makefile.in: Fix gcov dependencies that should not point to a build folder.