On 06/05/2015 12:33 PM, Aldy Hernandez wrote:
+  /* The tree for which this DIE was created for.  We use this to

Too many "for"s.

-  fprintf (outfile, "DIE %4ld: %s (%p)\n",
+  fprintf (outfile, "DIE %4ld: %s (%p)",
           die->die_offset, dwarf_tag_name (die->die_tag),
           (void*) die);
+  fputc ('\n', outfile);

I don't think you need this change.

   else if (declaration)
-    gen_formal_types_die (decl, subr_die);
+    {
+      /* Only generate a prototype's parameters once.  */
+      if (!old_die)
+       gen_formal_types_die (decl, subr_die);
+    }

I think this is dead code now, since you return early if declaration && old_die.

OK with those changes.

Jason

Reply via email to