Maciej W. Rozycki <ma...@linux-mips.org> writes:
> Richard, please have a look at my question below in a reference to your
> previous statement.
> 
> On Thu, 18 Jun 2015, Steve Ellcey wrote:
> 
> > OK, I checked in the prequel patch and here is a new copy of the
> > original patch based off of that (and with no HONOR_NAN checks in the
> > fma/madd instructions).
> >
> > OK for checkin?
> 
>  Please see below for my notes.
> 
> > 2015-06-18  Steve Ellcey  <sell...@imgtec.com>
> >
> >     * config.gcc (mips*-*-*): Add fused-madd.opt.
> 
>  Please use angle brackets as per
> <https://www.gnu.org/prep/standards/html_node/Indicating-the-Part-Changed.html>,
> i.e.:
> 
>       * config.gcc <mips*-*-*>: Add fused-madd.opt.
> 
> There's no function or similar entity involved here and `mips*-*-*' is a
> case value like with the C language's `switch' statement where you'd use
> angle brackets too to refer to individual cases.
> 
> >     (*nmsub4<mode>_fastmath)  Update condition.
> 
>  Extraneous space here.
> 
>  The change looks good to me otherwise.
> 
>   Maciej

If nobody can identify any further functional issues with this patch then
I'd like to get this committed and pursue enhancements as a second round.
Catherine, would you be happy for this to be committed on that basis?

Thanks,
Matthew

Reply via email to