Hi Paul,

I don’t feel confident enough in many parts of the code (including the module 
part) to formally review it, but from what I’ve read it seemed rather logical 
and well-commented. If it regtests fine, I think your plan (especially at the 
current GCC stage) of committing this week is sound.

One question I had is: does this change the .mod file format in any case? I 
don’t think, cause you don’t seem to bump the version number, but have you 
checked on specific cases (like, the mega cp2k example) that the patch indeed 
does not change existing module files (the ones that do not use submodules)?

Cheers, and thanks for this patch!

FX

Reply via email to