On 07/10/2015 02:47 PM, Andrew MacLeod wrote:
I noticed a few annoying bits around the graphite files that I decided
to cleanup.

- omega.h shouldn't include "config.h".  including params.h is fine
since it is needed, but it should be within the #ifndef GCC_OMEGA_H guard.
- sese.h is required for compilation of graphite-poly.h, and basically
isn't used anywhere else (except sese.c) , so simply include it in
graphite-poly.h.
- I adjusted the rest of the graphite files . All but graphite.c guard
the enter contents of the file with HAVE_isl, but they all include a ton
of GCC includes outside the guard.  I moved them inside the guard and
ran include reduction on them all to remove the unneeded headers.
- graphite.c was similar, except it has a small hunk of code which is
compiled when HAVE_isl is false. I manually adjusted those includes to
be minimal, and ran include reduction on the rest.

I bootstrapped with HAVE_isl defined and also with it not defined on
x86_64-unknown-linux-gnu.  I ran it with no regressions with HAVE_isl
defined.

OK for trunk?
OK.
jeff

Reply via email to