On Tue, Jul 14, 2015 at 07:06:52AM -0700, Aldy Hernandez wrote: > On 07/13/2015 06:56 AM, Jakub Jelinek wrote: > >On Sat, Jul 11, 2015 at 11:35:36AM -0700, Aldy Hernandez wrote: > > Everything addressed except this, which I'll address as a follow-up: > > >If you want to spend time on something still in the FE, it would be nice to > >resolve the C++ iteration var issue (i.e. increase OMP_FOR number of > >arguments, so that it could have yet another (optional) vector, say > >OMP_FOR_ORIG_DECLS. If that vector would be NULL, the gimplifier would > >assume that all the decls in OMP_FOR_INIT are the ones present in the > >source, if it would be present, you'd use them for the variable checking > >instead of the ones from OMP_FOR_INIT (but, replace them with the > >decls from OMP_FOR_INIT after the checking). > > > >There is another issue - if some iterator var has pointer type, supposedly > >we want somewhere in the FEs already multiply it by the size of what they > >point to (and convert to sizetype). For C FE, it can be done already during > >parsing, we should know the type of the iterator var already at that point, > >for C++ FE it needs to be done only in finish_omp_clauses if > >!processing_template_decl, because in templates we might not know the type. > > Tested on x86-64 Linux. > > Ok for branch?
Can you please fix: Blocks of 8 spaces should be replaced with tabs. 248:+ (parser, identifier, 579:+ stmt->code == GIMPLE_OMP_ORDERED. */ 798:+ (gimple_omp_for_clauses (octx->stmt), 914:+ for (k = 0; k < o; k++) 915:+ { 932:+ bar (i, j, 0); 955:+ bar (i, j, 0); 973:+ (s1, (in the patch on lines starting with + replace sequences of 8 spaces with tabs)? Ok with that, thanks. Jakub