Hi, On Mon, 25 Jul 2011, Richard Henderson wrote:
> >> But the only real consumer of BB_PARTITION is pass_reorder_blocks. > >> And that pass is already gated to only run if optimization is > >> enabled. So really there's no point in running this pass without > >> optimization. > >> > >> Committed. > > > > Why not simply move pass_df_initialize_no_opt earlier? Introducing > > more checks on optimize instead of only relying on flag_xxx seems to > > go the wrong direction. > > Primarily because of pass_reorder_blocks not running. Yeah, well, that just means pass_reorder_blocks also could do with a better gate (indeed it doesn't do much except a CFG cleanup when neither flag_reorder_blocks nor flag_reorder_blocks_and_partition is set). Granted there are currently > 320 tests for optimize, so we'll survive one more, it just felt wrong. Ciao, Michael.
