On 07/18/15 11:37, Thomas Schwinge wrote:
Hi Nathan!
On Thu, 09 Jul 2015 20:25:22 -0400, Nathan Sidwell <nat...@acm.org> wrote:
This is the patch I committed. [...]
Prompted by your recent "-O0 patch" to »[f]ix PTX worker spill/fill«, I
used the attached patch 0001-O0-libgomp-C-C-testing.patch to run all C
and C++ libgomp testing with -O0 (for Fortran, we iterate through various
kinds of optimization levels anyway). (There are no regressions of
OpenMP testing.)
For OpenACC nvptx offloading, there must still be something wrong; here's
a count of the (non-deterministic!) regressions of ten runs of the
libgomp testsuite. As private-vars-loop-worker-5.c fails most often, it
probably makes sense to look into that one first.
For avoidance of doubt, there are no such regressions if I un-apply your
patch to »[m]ove openacc vector& worker single handling to RTL«.
I cannot reproduce the failures. Applying your patch I see the following new
fails:
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/lib-5.c
-DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-local-worker-3.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 e
xecution test
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worker-7.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 ex
ecution test
FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/present-1.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 output pattern te
st, is , should match present clause: !acc_is_present
FAIL:
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-local-worker-2.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0
execution test
FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-vector-1.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0
execution test
FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-4.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0
execution test
FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-5.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0
execution test
Which differs from your list. Attempting to reproduce outside the test suite
results in working executables.
nathan
--
Nathan Sidwell
