On Fri, Jul 24, 2015 at 09:21:46AM +0100, Kyrill Tkachov wrote: > > Thanks for the review, here's an updated version. > In the end, I chose to retain the use alloca (other patches in the series > are reworked to use it too). > > How's this?
A nit or two from code you were moving or that got caught up in the diff, but otherwise OK to commit with the issues highlighted below fixed up. > > - aarch64_build_bitmask_table (); > +/* Validate a command-line -mcpu option. Parse the cpu and extensions (if > any) > + specified in STR and throw errors if appropriate. Put the results if > + they are valid in RES and ISA_FLAGS. */ > +static void > +aarch64_validate_mcpu (const char *str, const struct processor **res, > + unsigned long *isa_flags) Newline between comment and function. > +/* Validate a command-line -march option. Parse the arch and extensions > + (if any) specified in STR and throw errors if appropriate. Put the > + results, if they are valid, in RES and ISA_FLAGS. */ > +static void > +aarch64_validate_march (const char *str, const struct processor **res, > + unsigned long *isa_flags) And here. > +/* Validate a command-line -mtune option. Parse the cpu > + specified in STR and throw errors if appropriate. Put the > + result, if it is valid, in RES. */ > +static void > +aarch64_validate_mtune (const char *str, const struct processor **res) And here. Thanks, James
