On Tue, Aug 4, 2015 at 2:15 PM, Richard Biener <rguent...@suse.de> wrote:
>> This patch adds scatter support for vectorizer (for AVX512F >> instructions). Please have a look. Is it OK for trunk? > > +/* Target builtin that implements vector scatter operation. */ > +DEFHOOK > +(builtin_scatter, > + "", > + tree, > + (const_tree vectype, const_tree index_type, int scale), > + NULL) > > please add documentation inline here, like for builtin_gather, > and let tm.texi be auto-populated. > > Note that the i386 changes need target maintainer approval, CCing > Uros. As said many times, please don't mix middle-end and target parts into one patch. Middle-end part (usually algorithmic one) has to be discussed, reviewed and approved first, and at that stage, the target part can be used as an implementation example. Only *after* approval of the middle-end part, target part can be reviewed. Not to mention that every part has different reviews, so the review of the patch can stall due to this fact. Uros.
