On Wed, Jul 27, 2011 at 9:49 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Wed, Jul 27, 2011 at 6:12 PM, Kirill Yukhin <kirill.yuk...@gmail.com> > wrote: >> Than as it is ABM header, it should include two headers: lzcntinrin.h >> and popcntintrin.h >> >> But again, it seems useless to me. If we cannot remove empty header, >> let it stay empty... >> >> K >> >> On Wed, Jul 27, 2011 at 7:53 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >>> On Wed, Jul 27, 2011 at 8:45 AM, Kirill Yukhin <kirill.yuk...@gmail.com> >>> wrote: >>>> Just have a closer look to ABM intrinsics support in GCC >>>> Seems, we have popcnt support in separate file: popcntintrin.h >>>> >>>> So, after I move lzcnt intrinsics to lzcntintrin.h, abmintrin will >>>> become useless and have to be removed at all >>> >>> We can't remove an installed header file. It should just include >>> other header files. > > ambintrin.h has: > > #ifndef _X86INTRIN_H_INCLUDED > # error "Never use <abmintrin.h> directly; include <x86intrin.h> instead." > #endif > > I see no problem in removing this header. It is not possible to > #include it directly. >
Sounds good to me. -- H.J.
