On Tue, Aug 25, 2015 at 10:35:37AM -0700, Aldy Hernandez wrote: > diff --git a/libgomp/env.c b/libgomp/env.c > index 65a6851..0569521 100644 > --- a/libgomp/env.c > +++ b/libgomp/env.c > @@ -69,7 +69,7 @@ struct gomp_task_icv gomp_global_icv = { > > unsigned long gomp_max_active_levels_var = INT_MAX; > bool gomp_cancel_var = false; > -int gomp_max_task_priority_var = 0; > +static int gomp_max_task_priority_var = 0; > #ifndef HAVE_SYNC_BUILTINS > gomp_mutex_t gomp_managed_threads_lock; > #endif
Please remove this hunk. The variable is meant to be used in task.c, where (void) priority; is present right now (like: if (priority > gomp_max_task_priority_var) priority = gomp_max_task_priority_var; or so. > @@ -110,7 +112,12 @@ static void gomp_task_maybe_wait_for_dependencies (void > **depend); > > /* Called when encountering an explicit task directive. If IF_CLAUSE is > false, then we must not delay in executing the task. If UNTIED is true, > - then the task may be executed by any member of the team. */ > + then the task may be executed by any member of the team. > + > + DEPEND is an array containing: > + depend[0]: number of depend elements. > + depend[1]: number of depend elements of type "out". > + depend[N+2]: address of [0..N]th depend element. */ Either [1..N]th, or [0..N-1]th. And depend[N+2] should better be depend[2..N+1]. Otherwise LGTM. Jakub