On 03/09/15 12:19, Jakub Jelinek wrote:
@@ -292,7 +292,7 @@ gomp_team_start (void (*fn) (void *), void *data, unsigned
nthreads,
> bool nested;
> struct gomp_thread_pool *pool;
> unsigned i, n, old_threads_used = 0;
>- pthread_attr_t thread_attr, *attr;
>+ pthread_attr_t mutable_attr, *attr;
Just wonder why have you renamed this variable. It is a thread attribute
after all, even after your changes. mutable_attr doesn't make much sense to
me.
We have only thread attributes in this function: mutable_attr and attr.
The attr is initialized with &gomp_thread_attr and gomp_thread_attr is
supposed to be read-only by this function. Under certain conditions we
have to modify the initial attributes. Since gomp_thread_attr is
read-only, we have to copy it and then modify the copy. For this we need
some storage: mutable_attr.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
