On Fri, Sep 25, 2015 at 5:04 PM, James Greenhalgh <james.greenha...@arm.com> wrote: > > Hi, > > This patch is a simple prototype showing how a target might choose > to implement TARGET_COSTS_IFCVT_NOCE_IS_PROFITABLE_P. It has not been > tuned, tested or looked at in any meaningful way. > > While the patch is in need of more detailed analysis it is sufficient to > serve as an indication of what direction I was aiming for with this > patch set. > > Clearly this is not OK for trunk without further work, but I thought I'd > include it as an afterthought for the costs rework.
First of all don't include math.h or use FP math on the host. If you need fractional arithmetic use sreal. It looks like with your hook implementation you are mostly hiding magic numbers in the target. I'm not sure how this is better than exposing them as user-accessible --params (and thus their defaults controllable by the target). Richard. > Thanks, > James > > --- > 2015-09-26 James Greenhalgh <james.greenha...@arm.com> > > * config/aarch64/aarch64.c > (aarch64_additional_branch_cost_for_probability): New. > (aarch64_ifcvt_noce_profitable_p): Likewise. > (TARGET_COSTS_IFCVT_NOCE_PROFITABLE_P): Likewise. >
