On Tue, Sep 29, 2015 at 7:43 AM, Tom de Vries <tom_devr...@mentor.com> wrote: > [ was: Re: [RFC] Dump function attributes ] > > On 28/09/15 17:17, Bernd Schmidt wrote: >> >> On 09/28/2015 04:32 PM, Tom de Vries wrote: >>> >>> patch below prints the function attributes in the dump file. >> >> >>> foo () >>> [ noclone , noinline ] >>> { >>> ... >>> >>> Good idea? >>> >>> If so, do we want one attribute per line? >> >> >> Only for really long ones I'd think. Patch is ok for now. >> >> > > Reposting patch with ChangeLog entry added. > > Bootstrapped and reg-tested on x86_64. > > Committed to trunk.
Hmpf. I always like to make the dump-files as much copy&past-able to testcases as possible. So why did you invent a new syntax for attributes instead of using the existing __attribute__(("noclone", "noinline")) (in this case)? Did you verify how attributes with arguments get printed? Thanks, Richard. > > Thanks, > - Tom