On Thu, Oct 01, 2015 at 07:39:10PM -0400, Rich Felker wrote: > On Fri, Oct 02, 2015 at 07:36:27AM +0900, Oleg Endo wrote: > > On Thu, 2015-10-01 at 17:35 -0400, Rich Felker wrote: > > > This is a forward-port of the abandoned SH FDPIC patch from 2010: > > > > > > https://gcc.gnu.org/ml/gcc-patches/2010-08/msg01536.html > > > > > > I'm submitting it at this point for initial review, not to be applied > > > right away; I would not be surprised if some changes are needed. It > > > applies on top of gcc 5.2.0 with the patch for pr 66609 applied. With > > > one trivial change it also applies to the current development version > > > of gcc, but I have not tested that setup. > > > > Thanks for working on this. Please submit a patch against trunk. > > I'm going to go ahead and submit the patch adjusted for trunk, but I > have not yet tested it yet -- I can't get trunk to build because of a > regression. Apparently someone added -fno-PIE to the build process, > which breaks when the host toolchain you're building with uses -pie by > default. Is this a known issue?
I worked around it and opened an issue for it: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67812 But trying the patch on vanilla GCC trunk without my usual J2 target setup revealed some additional issues I need to address. I'm getting ICE in the code that generates the libgcc bitshift calls, which weren't used on J2. This is my fault for failing to extend the changes made to other parts of sh.md to the patterns for the new shifts (the same ones that broke the kernel) and perhaps also some other things. I'm going to go back and review that code and get it done right before resubmitting the patch against trunk. If you have any other general comments on the patch in the mean time I'd be happy to hear them. Rich
