Richard Biener <richard.guent...@gmail.com> writes: > On Thu, Oct 1, 2015 at 3:52 PM, Bernd Schmidt <bschm...@redhat.com> wrote: >> On 10/01/2015 03:48 PM, Richard Sandiford wrote: >>> >>> ...which simplifies the match.pd patterns I'm about to add. >>> >>> Bootstrapped & regression-tested on x86_64-linux-gnu. OK to install? >> >> >> Ok. > > I wonder if it's worth a separate function - why not truncate > unconditionally in build_real?
I suppose build_real would then be doing implicit rounding, whereas it sounds like it should just be converting between representations. The new function makes it explicit that the value is being changed in the process. > In fact it looks like we might have non-canonical REAL_CSTs with > excess precision? Maybe there should be an assert in build_real to catch that? Although I don't really have time to offer to do that. If you think we have a bug here then I can file a PR. Thanks, Richard
