On Wed, Jul 8, 2015 at 1:35 PM, H.J. Lu <hjl.to...@gmail.com> wrote: > On Sun, Jul 5, 2015 at 2:54 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >> On Sun, Jul 5, 2015 at 11:14 AM, H.J. Lu <hjl.to...@gmail.com> wrote: >>> Update default_elf_asm_output_external to also output symbol type to >>> help ELF linker to properly issue diagnostic message. We don't output >>> symbol type for reference to external TLS symbol since assembler will >>> generate TLS symbol type based on TLS relocation and Solaris assembler >>> only supports the @tls_obj type directive, not the @tls_object type >>> directive used by GNU assmbler, which doesn't understand the @tls_obj >>> type directive. >>> >>> Tested on Linux/x86-64. OK for trunk? >>> >>> Thanks. >>> >>> >>> H.J. >>> --- >>> gcc/ >>> >>> PR target/35514 >>> * varasm.c (default_elf_asm_output_external): Also output symbol >>> type. >>> >>> gcc/testsuite/ >>> >>> PR target/35514 >>> * lib/target-supports.exp (check_effective_target_elf): New. >>> * gcc.dg/pr35514-1.c: New file. >>> * gcc.dg/pr35514-2.c: Likewise.
> > Here is the updated patch to adjust those tests by counting in > the .type directive for ELF targets. There is no regression on > Linux/x86-64. OK for trunk? > PING: https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00652.html -- H.J.
