> In this case, I think it is better to write this part as: > > --cut here-- > offset += 8; > > /* Always preserve double-word alignment. */ > offset = ROUND_DOWN (offset, 8); > --cut here--
Not convinced, having offset == 12 after the first line doesn't make sense. I'd just beef up the comment: /* Bump and round down to double word in case we already bumped by 4. */ offset = ROUND_DOWN (offset + 8, 8); -- Eric Botcazou
