> > I'm not sure we need to care about TYPE_ALIGN_OK here so no objection by me. > > Actually I have one: can we please fix the multiple Ada breakages caused by > the previous controversial change from Jan before going farther in the series? > The build is still broken on IA-64 and I'm still seeing ICEs on x86. Or else > can we put the whole series on a branch until it is reasonably stable?
I wasn't aware that x86/IA-64 is still broken. I am flying to NY tomorrow but will try to take a look. The ICEs are not caused by operand_equal_p changes, but the change to useless_type_conversion to ignore mode on aggregate types. A safe way would be to add the mode check back (as was in my original patch) that does not change my original intent to separate CANONICAL_TYPE from gimple semantic type equivalence machinery. It was however outcome of the discussion that we would preffer the mode to be ignored in this case which means fixing expansion side. I have no way to reproduce the IA-64 change, but will send proposed patch - from backtrace it was clear where the wrong mode went in. Will wait with operand_euqal_p changess until this is fixed. Honza > > -- > Eric Botcazou
