On 10/06/2015 06:40 AM, Bernd Schmidt wrote:
I'm not entirely sure what to make of this series. There seem to be good
bits in there but also some things I find questionable. I'll add some
comments on things that occur to me.

On 10/06/2015 01:28 AM, Mikhail Maltsev wrote:

    * include/line-map.h: Fix use of ENABLE_CHECKING.

Fix how? What's wrong with it?
I think it was just a poor choice of words for the ChangeLog.


Probably a good thing, but it looks like libcpp has grown its own
variant linemap_assert; we should check whether that can be replaced.
Agreed.  Let's push it onto the queue of things to clean up.

jeff

Reply via email to