On Sun, Oct 25, 2015 at 11:28:51PM +0900, Oleg Endo wrote: > On Fri, 2015-10-23 at 02:32 -0400, Rich Felker wrote: > > Here's my updated version of the FDPIC patch with all requested > > changes made and Changelog added. I've included all the original > > authors. This is my first time writing such an extensive Changelog > > entry so please let me know if there are things I got wrong. > > I took the liberty and fixed some minor formatting trivia and extracted > functions sh_emit_storesi and sh_emit_storehi which are used in > sh_trampoline_init to effectively memcpy code into the trampoline > area. Can you please check it? If it's OK I'll commit the attached > patch to trunk.
Is there anything in particular you'd like me to check? It builds fine for fdpic target, successfully compiles musl libc.so, and busybox runs with the resulting libc.so. I did a quick visual inspection of the diff between my version and yours too and didn't see anything that looked suspicious to me. Rich