Hi! On Thu, 5 Nov 2015 10:41:41 -0500, Nathan Sidwell <nat...@acm.org> wrote: > On 11/05/15 10:29, Jakub Jelinek wrote: > > I've merged the current state of gomp-4_5-branch into trunk, after > > bootstrapping/regtesting it on x86_64-linux and i686-linux. > > > > There are > > +FAIL: gfortran.dg/goacc/private-3.f95 -O (test for excess errors) > > +FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/loop-red-v-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 (test for excess errors) > > +UNRESOLVED: libgomp.oacc-c/../libgomp.oacc-c-c++-common/loop-red-v-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 compilation failed to produce > > executable > > +FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/loop-red-w-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 (test for excess errors) > > +UNRESOLVED: libgomp.oacc-c/../libgomp.oacc-c-c++-common/loop-red-w-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 compilation failed to produce > > executable > > +FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/loop-red-v-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 (test for excess errors) > > +UNRESOLVED: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/loop-red-v-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 compilation failed to produce > > executable > > +FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/loop-red-w-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 (test for excess errors) > > +UNRESOLVED: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/loop-red-w-2.c > > -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 compilation failed to produce > > executable > > regressions, but I really don't know why OpenACC allows reductions against > > private variables, so either the testcases are wrong, or if OpenACC > > reduction can work against private vars (automatic vars inside of parallel > > too?), then perhaps it shouldn't set check_non_private for OpenACC > > reduction clauses or something similar. Certainly, if there is private > > on the target region, returning 1 from omp_check_private is IMNSHO desirable > > (and required for OpenMP at least). > > I'm working on porting patches for that, and I had noticed the > check_non_private > anomoly earlier today ... > > I believe the c/c++ test cases are valid OpenACC, FWIW. (not checked the > fortran > one yet)
If that helps, this functionality ("private variable may also appear
inside a reduction clause"), and the Fortran test case got added by Cesar
in gomp-4_0-branch r215038,
<http://news.gmane.org/find-root.php?message_id=%3C53E957F0.3090908%40codesourcery.com%3E>.
> Anyway, thanks for the heads-up, my ball.
Meanwhile, XFAILed in r229841:
commit 6e9b4ab07e26928819f04e39c20cb3cfceda9740
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Fri Nov 6 11:11:34 2015 +0000
XFAIL testcases regressed after r229814, "Merge from gomp-4_5-branch to
trunk"
gcc/testsuite/
* gfortran.dg/goacc/private-3.f95: XFAIL.
libgomp/
* testsuite/libgomp.oacc-c-c++-common/loop-red-v-2.c: XFAIL.
* testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c: Likewise.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@229841
138bc75d-0d04-0410-961f-82ee72b054a4
---
gcc/testsuite/ChangeLog | 4 ++++
gcc/testsuite/gfortran.dg/goacc/private-3.f95 | 3 ++-
libgomp/ChangeLog | 5 +++++
libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-v-2.c | 2 ++
libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c | 2 ++
5 files changed, 15 insertions(+), 1 deletion(-)
diff --git gcc/testsuite/ChangeLog gcc/testsuite/ChangeLog
index af9bd72..b0e78e9 100644
--- gcc/testsuite/ChangeLog
+++ gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-11-06 Thomas Schwinge <tho...@codesourcery.com>
+
+ * gfortran.dg/goacc/private-3.f95: XFAIL.
+
2015-11-06 Joost VandeVondele <vond...@gnu.gcc.org>
PR middle-end/53852
diff --git gcc/testsuite/gfortran.dg/goacc/private-3.f95
gcc/testsuite/gfortran.dg/goacc/private-3.f95
index aa12a56..af7d683 100644
--- gcc/testsuite/gfortran.dg/goacc/private-3.f95
+++ gcc/testsuite/gfortran.dg/goacc/private-3.f95
@@ -1,4 +1,6 @@
! { dg-do compile }
+!
<http://news.gmane.org/find-root.php?message_id=%3C563B78B5.5090506%40acm.org%3E>
+! { dg-xfail-if "TODO" { *-*-* } }
! test for private variables in a reduction clause
@@ -7,7 +9,6 @@ program test
integer, parameter :: n = 100
integer :: i, k
-! FIXME: This causes an ICE in the gimplifier.
! !$acc parallel private (k) reduction (+:k)
! do i = 1, n
! k = k + 1
diff --git libgomp/ChangeLog libgomp/ChangeLog
index 26377b6..ab2a25a 100644
--- libgomp/ChangeLog
+++ libgomp/ChangeLog
@@ -1,3 +1,8 @@
+2015-11-06 Thomas Schwinge <tho...@codesourcery.com>
+
+ * testsuite/libgomp.oacc-c-c++-common/loop-red-v-2.c: XFAIL.
+ * testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c: Likewise.
+
2015-11-05 Jakub Jelinek <ja...@redhat.com>
Ilya Verbin <ilya.ver...@intel.com>
diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-v-2.c
libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-v-2.c
index e66732d..fbed589 100644
--- libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-v-2.c
+++ libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-v-2.c
@@ -1,5 +1,7 @@
/* { dg-do run } */
/* { dg-additional-options "-O2" */
+/*
<http://news.gmane.org/find-root.php?message_id=%3C563B78B5.5090506%40acm.org%3E>
+ { dg-xfail-if "TODO" { *-*-* } } */
#include <stdio.h>
diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c
libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c
index 0059077..47f1da0 100644
--- libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c
+++ libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c
@@ -1,5 +1,7 @@
/* { dg-do run } */
/* { dg-additional-options "-O2" */
+/*
<http://news.gmane.org/find-root.php?message_id=%3C563B78B5.5090506%40acm.org%3E>
+ { dg-xfail-if "TODO" { *-*-* } } */
#include <stdio.h>
Grüße
Thomas
signature.asc
Description: PGP signature
