On 11/09/2015 02:32 PM, Robert Suchanek wrote:
The results below were generated for CSiBE benchmark and the numbers in
columns express bytes in format 'net (gain/loss)' to show the difference
with and without the patch when -frename-registers switch is used.

I'm not entirely sure what the numbers represent. I can see how you'd measure at a net size change (I assume a negative net is the intended goal), but how did you arrive at gain/loss numbers?

In any case, assuming negative is good, the results seem pretty decent.

+             gcc_assert
+               (terminated_this_insn->regno == REGNO (recog_data.operand[1]));

Maybe break the line before the == so that you can start the arguments on the same line as the assert.

+  /* Nonzero if the chain is renamed.  */
+  unsigned int renamed:1;

I'd write "has already been renamed" since that is maybe slightly less ambiguous.

Ok with those changes.


Bernd

Reply via email to