On Wed, Nov 11, 2015 at 12:19:55PM -0500, Nathan Sidwell wrote:
> this patch implements default data attribute determination. The current
> behaviour defaults to 'copy' and ignores 'default(none)'. The patch
> corrects that.
>
> 1) We emit a diagnostic when 'default(none)' is in effect. The fortran FE
> emits some artificial decls that it doesn't otherwise annotate, which is why
> we check DECL_ARTIFICIAL. IIUC Cesar had a patch to address that but it
> needed some reworking?
I don't think treating DECL_ARTIFICIAL specially is a bug of any kind,
there are tons of different artificals even for C/C++ VLAs etc., and user
has no way to put them into any clauses explicitly, so what we do with them
is GCC internal thing.
> 2015-11-11 Nathan Sidwell <nat...@codesourcery.com>
>
> gcc/
> * gimplify.c (oacc_default_clause): New.
> (omp_notice_variable): Call it.
>
> gcc/testsuite/
> * c-c++-common/goacc/data-default-1.c: New.
>
> libgomp/
> * testsuite/libgomp.oacc-c-c++-common/default-1.c: New.
+ error ("%qE not specified in enclosing OpenACC %s construct",
+ DECL_NAME (lang_hooks.decls.omp_report_decl (decl)), rkind);
+ error_at (ctx->location, "enclosing OpenACC %s construct", rkind);
I'd use %qs instead of %s.
Otherwise ok.
Jakub
