On Nov 16, 2015, at 3:12 PM, Jeff Law <l...@redhat.com> wrote: > So I'd tend to want them either at the end of the file with a single #if > CHECKING_P or as a separate foo-tests file.
Hum… I kinda don’t want the main files mucked up with tests. I think I’d rather have #if CHECKING_P #include "test/expr-test.h" #endif at the end, and punt the whole lot into a single subdirectory that most people, most of the time, can simply ignore. Wading through a ton of code that you aren’t interested in, is, well, annoying. We so rarely change apis that I don’t see the harm in the separation. Since we default to testing, and since the test suite will horrifically fail (if it works) if people do it wrong, I don’t think people will forget to update the test suite as the apis change. > I'm leaning towards suggesting we get on a branch and look to merge it into > the next stage1. This isn't something that's going to have a user impact. Depends on the patch set, but, I’d like to think most would be fairly safe to put in post stage 1.
