On 11/19/2015 06:58 AM, Bernd Schmidt wrote:
On 11/19/2015 11:16 AM, Martin Liška wrote:
You are right, however as the original coding style was really broken,
it was much easier
to use the tool and clean-up fall-out.
Waiting for thoughts related to v2.
Better, but still some oddities. I hope you won't get mad at me if I
suggest doing this in stages? A first patch could just deal with
non-reformatting whitespace changes, such as removing trailing
whitespace, and converting leading spaces to tabs - that would be
mechanical, and reduce the size of the rest of the patch (it seems emacs
has an appropriate command, M-x whitespace-cleanup). Such a change is
preapproved.
I was going to suggest the same after seeing the fallout. Trailing
whitespace and tabs/spaces sanity first. Those are easy to verify as
well using diff -b. Then follow-up with others.
I don't mind gating this in, but we're probably very close to a point
where this kind of change will need to wait for the next stage1.
Jeff
