On 11/25/2015 01:26 PM, Richard Sandiford wrote:
Later patches in the series add a new form of attribute that takes the
attribute number as an argument, rather than it being stored in the
global which_alternative variable.

Having both a local alternative number and a global alternative number
is likely to cause confusion.  This patch therefore gets rid of the
global variable.

I don't really feel that this is appropriate for this stage, and some of the formatting changes are pretty ugly. I'd put this pattern
  constrain_operands (1, get_enabled_alternatives (temp)) >= 0
into an inline function
  constraints_ok_p (temp).
and possibly also have a variant with an extract_insn call, similar to extract_constrain_insn.

Do any of the subsequent patches actually depend on this?


Bernd

Reply via email to