On Wed, Nov 11, 2015 at 17:56:15 +0300, Aleksander Ivanyushenko wrote:
> On Mon, Aug 24, 2015 at 10:45:03 +0200, Jakub Jelinek wrote:
> > On Thu, Aug 06, 2015 at 05:34:56PM +0300, Maxim Blumental wrote:
> > > Applied the idea with python script alternative. Review, please.
> >
> > > 2015-07-28 Maxim Blumenthal <maxim.blument...@intel.com>
> > >
> > > * configure.ac: Add a check for xxd or python presence when the target
> > > is intelmic or intelmicemul.
> > > * configure: Regenerate.
> > > * liboffloadmic/plugin/Makefile.am: Add a condition into
> > > make_target_image.h generating code. This condition performs an
> > > action with either xxd or a special python script during the
> > > generating.
> > > * liboffloadmic/plugin/xxd.py: New file.
> > > * liboffloadmic/plugin/Makefile.in: Regenerate.
> >
> > I still don't like this, there should be no `which ...` uses in the
> > Makefile.
> > Instead, use AC_CHECK_PROG/AC_CHECK_PROGS in configure.ac, for python
> > perhaps search for python python2 python3 or what is common in the python
> > land. And prepare the command line to use in the Makefile.am in configure
> > too, then AC_SUBST it and use the variable in there (and the variable will
> > use $@ etc.).
> Maxim has left Intel so I have fixed this issue. I tried to build with and
> without xxd, so everything works fine. ok for trunk?
>
> 2015-11-10 Aleksander Ivanushenko <aleksander.ivanushe...@intel.com>
> Maxim Blumenthal <maxim.blument...@intel.com>
>
> * configure.ac: Add xxd and python check for intelmic and
> intelmicemul.
> * configure: Regenerate.
>
> liboffloadmic/
> 2015-11-10 Aleksander Ivanushenko <aleksander.ivanushe...@intel.com>
> Maxim Blumenthal <maxim.blument...@intel.com>
> David Malcolm <dmalc...@redhat.com>
>
> * plugin/xxd.py: New file.
> * plugin/configure.ac: Add searching for xxd and python pathes.
> * plugin/Makefile.am: Add python script usage in case when xxd is not
> available.
> * plugin/configure: Regenerate.
> * plugin/Makefile.in: Regenerate.
>
>
Ping.
