On 12/01/2015 01:16 PM, Richard Biener wrote:
On Tue, Dec 1, 2015 at 12:54 PM, Bernd Schmidt <bschm...@redhat.com> wrote:
On 11/26/2015 05:22 PM, Richard Sandiford wrote:
Bernd Schmidt <bschm...@redhat.com> writes:
I wish we'd taken some more time to think through the consequences of
the original internal_fn patchset.
I don't think this PR shows that the approach was wrong.
I think it does. Internal functions make a new assumptions, that expanders
don't FAIL - but as we've now seen, they do. The optimize_size thing is
reasonably easy to grep for and it looks like only i386 is affected, but
have you looked at every expander in every port that could be used by an
internal function to ensure it does not FAIL for a different reason?
Of course we are not sure.
Hence, the correct approach for gcc-6 is to recognize that these patches
were not ready, and disable the new functionality IMO. I'm not
suggesting reverting the patches just yet, maybe we can solve these
issues for gcc-7.
Do you have even a guess as to how to approach the issue differently?
Not off-hand. That's not a question we're facing for stage3 though, and
I'd rather take a cautious approach than go deeper into the hole.
Bernd
