On Tue, Dec 01, 2015 at 11:48:51AM +0300, Ilya Verbin wrote:
>
> > On 01 Dec 2015, at 11:18, Jakub Jelinek <ja...@redhat.com> wrote:
> >
> >> On Mon, Nov 30, 2015 at 11:55:20PM +0300, Ilya Verbin wrote:
> >> Ok, but it doesn't solve the issue with doing it for the executable,
> >> because
> >> gomp_unmap_tgt (n->tgt) will want to run free_func on uninitialized device.
> >
> > ?? You mean that the
> > devicep->unload_image_func (devicep->target_id, version, target_data);
> > call deinitializes the device or something else (I mean, if there is some
> > other tgt, then it had to be initialized)?
>
> No, I mean that it can be deinitialized from plugin's __run_exit_handlers
> (see my last mail with the patch).
Then the bug is that you have too many atexit registered handlers that
perform some finalization, better would be to have a single one that
performs everything in order.
Anyway, the other option is in the atexit handlers (liboffloadmic and/or the
intelmic plugin) to set some flag and ignore free_func calls when the flag
is set or something like that.
Note library destructors can also use OpenMP code in them, similarly C++
dtors etc., so when you at some point finalize certain device, you should
arrange for newer events on the device to be ignored and new offloadings to
go to host fallback.
Jakub
