On Mon, Dec 07, 2015 at 12:17:58PM +0100, Martin Jambor wrote:
> Because I have not been able to come up with any solution to failing
> libgomp/testsuite/libgomp.c++/target-2.C, I have disabled use of
> dynamic parallelism in this merge (I keep it on the branch) and
> therefore entirely rely on the gridification process to run loops on
> the accelerator, because gridified constructs do not have this issue
> (passing private symbols by reference).
I'm fine with not doing it in this series, but I'd strongly prefer
if dynamic parallelism is added for GCC 6.1. Even for PTX we'll need
some IPA analysis on what functions might run in the various OpenMP
contexts (teams, parallel, simd) and what functions contains such
directives, and let the backends (or HSA) do something based on that
for sharing of the vars, or other properties of the function code
generation.
> HSA tests are still missing, I would need some guidance as to how to
> best implement them (specially to test gridification which of course
> does not happen for other accelerators). There are no failing
> testcases if HSA is not configured. If it is, there are some, all of
> which fall into one the following categories:
>
> 1) HSA cannot compile a function for one reason or another (most
> common cause is inability of HSA to take an address of a function
> or make an indirect call) and gives a warning, which is regarded
> as an "excess error" by dejagnu.
It would be good if there is a -W* switch to turn such warnings off.
Not just for the purposes of dejagnu libgomp testing, but say one
might try to compile a program primarily say for XeonPhi or PTX offloading,
but have HSA enabled to, but care primarily about the former two, etc.
> 2) When HSA is not emitted for a function, libgomp runs a host
> fallback instead of it. When the test queries
> omp_is_initial_device and asserts it returns false, the test
> fails.
Do you have examples of which tests fall into this category?
In any case, it will be needed to also update the wiki page with details on
how to build the HSA support in, what are the prerequisities etc.
Jakub
