On 12/07/2015 02:44 PM, Jakub Jelinek wrote:
So like this?
+/* Perform diagnostics for read_cmdline_option and control_warning_option
+ functions. Returns true if an error has been diagnosed. */
Let's document arguments; for the ones identical to read_cmdline_option
an explicit pointer there is sufficient, but errors is new.
@@ -1332,8 +1348,8 @@ get_option_state (struct gcc_options *op
used by -Werror= and #pragma GCC diagnostic. */
void
-control_warning_option (unsigned int opt_index, int kind, bool imply,
- location_t loc, unsigned int lang_mask,
+control_warning_option (unsigned int opt_index, int kind, const char *arg,
+ bool imply, location_t loc, unsigned int lang_mask,
This also needs an update to the function comment.
Other than that I'm ok with this. This area could probably be
restructured a bit but for now I think this is good enough.
Bernd
