On 12/09/2015 05:24 PM, Thomas Schwinge wrote:

In addition to that, how about we split up gcc/omp-low.c into several
files?  Would it make sense (I have not yet looked in detail) to do so
along the borders of the several passes defined therein?  Or, can you
tell already that there would be too many cross-references between the
several files to make this infeasible?

It would be nice to get rid of all the code duplication in that file. That alone could reduce the size by quite a bit, and hopefully make it easier to read.

I suspect a split along the ompexp/omplow boundary would be quite easy to achieve.

I'd suggest to do this shortly before GCC 6 is released, so that
backports from trunk to gcc-6-branch will be easy.  (I assume we don't
have to care for gcc-5-branch backports too much any longer.)

I'll declare myself agnostic as to whether such a change is appropriate for gcc-6 at this stage. I guess it kind of depends on the specifics.


Bernd

Reply via email to