David Malcolm wrote: > On Sat, 2015-12-05 at 20:53 +0100, Mikael Morin wrote: > > to get things moving again, a few comments on top of David Malcolm's: [...] > > It seems you are considering some candidates more than once here. [...] > > You have to start the lookup with the current namespace's sym_root (not > > with fun), otherwise you'll miss some candidates. > > You may also want to query parent namespaces for host-associated symbols. [...]
I think the current patch doesn't not address those (as stated) and I think that some suggestions should honour the attributes better (variable vs. subroutine vs. function etc.). But I very much like the general patch. Regarding Malcolm's update: > I can't comment on Mikael's observations, but here's an updated version > of Bernhard's patch which moves the duplicated code into a new > "find_closest_string" function in gcc/spellcheck.c. That change looks good to me. BTW: I think you should write a quip for https://gcc.gnu.org/gcc-6/changes.html Tobias PS: Talking about the release notes, my feeling is that both the wiki and the release notes miss some changes, but I have to admit that I am really out of sync. It currently only lists Submodules at the Wiki, https://gcc.gnu.org/wiki/GFortran/News#GCC6 and https://gcc.gnu.org/gcc-6/changes.html has a few other items. (Both should be synced crosswise.) As additional item, I know of coarray events but there must be more items.
