On Thu, Dec 10, 2015 at 05:05:12PM +0100, Bernd Schmidt wrote: > On 12/10/2015 03:36 PM, Kyrill Tkachov wrote: > >I'm okay with delaying this for next stage 1 if people prefer, though I > >think it's > >pretty low risk. > > I think this is something we should fix now.
I agree. > >+ x = XEXP (x, 0); > >+ if (start > 0) > >+ x = gen_rtx_LSHIFTRT (mode, x, GEN_INT (start)); > > I think this should just use simplify_shift_const. gen_rtx_FOO should be > avoided. A lot of combine does that, it really is stuck in the 80's. I wouldn't use simplify_shift_const here, but simply simplify_gen_binary. The patch is okay with or without that change. Segher
