On 12/11/2015 05:49 PM, Daniel Kahn Gillmor wrote:
I've re-rolled the patch (attached below, here) to use the ENV: prefix instead of the $.
It might be irrelevant at this point, but the "ENV:" prefix is used in AmigaOS and could be part of a filename.
+ if (0 == strncmp(ENV_PREFIX, arg, ENV_PREFIX_OFFSET)) + { + env = xstrndup (arg+ENV_PREFIX_OFFSET, p - (arg+ENV_PREFIX_OFFSET));
Spaces before ( and around operators like +. Please review our coding guidelines and have a look at the surrounding code.
Wouldn't it be simpler just to special-case -fdebug-prefix-map in gen_producer_string? The environment variable thing strikes me as unnecessary.
Bernd