Hi Jakub,

>> ok, I see.  I'm uncomfortable declaring the requirement this
>> indirectly/unobviously.  I'd rather add a requirement on cilkplus (we
>> have that effective-target keyword already) and update
>> check_effective_target_cilkplus in target-supports.exp for nvptx.
>
> That is what we have in the tree until yesterday and it has been very buggy
> (disabled all Cilk+ testing on all architectures).
> See PR68629 or the gcc-patches discussions about this for details.

I didn't mean to introduce a compile test like this, but simply return 0
for nvptx-*-* like we already do for avr-*-*.  The compile test is the
correct approach, actually, but would need to be done right...

Besides, doing the -fcilkplus as a link test had been wrong, anyway,
given that many cilkplus tests are compile only...

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to