On 31/12/15 20:54, Joseph Myers wrote:
On Sat, 26 Dec 2015, Thomas Preud'homme wrote:

+#define CMSE_TT_ASM(flags) \
+{ \
+  cmse_address_info_t result; \
+   __asm__ ("tt" # flags " %0,%1" \
+          : "=r"(result) \
+          : "r"(p) \
+          : "memory"); \
+  return result; \

Are the identifiers "result" and "p" really meant to be reserved by this
header (so that users can't have macros with those names before including
it), or should they actually be __result and __p (and likewise for any
other identifiers in this file not specified as reserved)?

+__extension__ void *
+cmse_check_address_range (void *p, size_t size, int flags);

Are "size" and "flags" really meant to be reserved?

+@item -mcmse
+@opindex mcmse
+Generate secure code as per ARMv8-M Security Extensions.

I think you also need a section in extend.texi much like the existing ACLE
section, to describe support for this as a language extension.


I'll change all non-reserved and 'not-ment-for-export' identifiers to be preceded by '__' and Ill also look into adding a section for ARMv8-M Security Extensions (CMSE) to extend.texi.

Thank you for your feedback.

BR,
Andre

Reply via email to