On Wed, Jan 13, 2016 at 9:04 PM, Tom de Vries <tom_devr...@mentor.com> wrote: > Hi, > > At r231739, there was an ICE when checking code generated by > oacc_xform_loop, in case the source contained an error. > > Due to seen_error (), gimplification during oacc_xform_loop bailed out, and > an uninitialized var was introduced. Because of gimplifying in ssa mode, > that caused an ICE. > > I can't reproduce this any longer, but I think the fix still makes sense. > The patch makes sure oacc_xform_loop gimplifies in non-ssa mode if > seen_error ().
I don't think it makes "sense" in any way. After seen_error () a following ICE will be "confused after earlier errors" in release mode and thus I think that's not an important problem to paper over with this kind of "hack". I'd rather avoid doing any of omp-low if seen_error ()? Richard. > Build on x86_64 with nvidia accelerator setup, tested libgomp and goacc.exp. > > Committed to gomp-4_0-branch. > > Thanks, > - Tom
