On Thu, Jan 14, 2016 at 5:34 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Thu, Jan 14, 2016 at 02:57:06PM -0700, Jeff Law wrote: >> On 01/14/2016 02:19 PM, Ryan Burn wrote: >> >This patch adds a missing cleanup point to cilk_spawn expressions to >> >prevent an ICE when calling functions that return types with >> >non-trivial destructors. >> > >> >Bootstrapped and regression tested on x86_64-linux. >> > >> >2015-01-14 Ryan Burn <cont...@rnburn.com> >> > >> > PR c++/69048 >> > * cilk.c (create_cilk_wrapper_body): Call >> >fold_build_cleanup_point_expr to add missing cleanup point. >> > >> > * gcc/testsuite/g++.dg/cilk-plus/CK/pr69048.cc: New test >> I thought something was horribly wrong for a few minutes. STMT inside >> cilk_create_wrapper_body is a tree, not a gimple statement. So my worries >> were unfounded :-) >> >> OK for the trunk. > > Note the ChangeLog entry is badly formatted (unless the MUA broke it). There > should be two spaces in between date and name instead of one, and the PR > line as well as all the other lines of entries should be tab indented, > and each description should end with full stop, and gcc/testsuite/ has its > own ChangeLog, so that part should go into that ChangeLog file and be > without prefix. > > 2015-01-14 Ryan Burn <cont...@rnburn.com> > > PR c++/69048 > * cilk.c (create_cilk_wrapper_body): Call > fold_build_cleanup_point_expr to add missing cleanup point. > > * g++.dg/cilk-plus/CK/pr69048.cc: New test. > > The > /* The statement containing the spawn expression might create temporaries > with > line is (1 char) too long, so you want to reformat that comment. > > Jakub
Are you sure? It passed the check_GNU_style.sh script. If you exclude the extra + added in the diff, it's within 80 characters.
