On 15/01/16 19:38, Andreas Krebbel wrote:
Marcin,
your implementation looks very good to me. Thanks!
But please be aware that we deprecated the support of g5 and g6 and intend to
remove that code from
the back-end with the next GCC version. So I would prefer if you could remove
all the
!TARGET_CPU_ZARCH stuff from the implementation and just error out if
split-stack is enabled with
-march g5/g6. It currently makes the implementation more complicated and would
have to be removed
anyway in the future.
Thanks!
https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01854.html
Bye,
-Andreas-
Very well, I'll do that.
Btw, as for dropping support for g5/g6: I've noticed
s390_function_profiler could also use larl+brasl for -m31 given
TARGET_CPU_ZARCH. Should I submit a patch for that? I'm asking because
gold with -fsplit-stack needs to know the exact sequence used, so if
it's going to change after g5/g6 removal, I'd better add it to gold now
(and make gcc always emit it for non-g5/g6, so that gold won't need to
look at the old one).
What about the other patches? #1 and #2 should be ready to go. I'm not
sure how I should go about getting #3 and #4 reviewed. We don't need #3
anymore once g5/g6 support is removed, but #4 might still be necessary -
we still have that unconditional jump.
Marcin Kościelnicki
