On Thu, Aug 11, 2011 at 14:14, Tobias Grosser <tob...@grosser.es> wrote:
> This needs to be adapted to my cloog.org interface patch.
I will adapt my patch set to be on top of your patch.
>> +/* Return an ISL identifier from the name of the ssa_name E. */
>> +
>> +static isl_id *
>> +isl_id_for_ssa_name (scop_p s, tree e)
>> +{
>> + const char *name = get_name (e);
>> + isl_id *id;
>> +
>> + if (name)
>> + id = isl_id_alloc (s->ctx, name, e);
>
> Does get_name() return always a unique name or is just the tuple
> (get_name(e), SSA_NAME_VERSION(e)) unique?
As we are using this function only on parameters, get_name should
return a unique name. I guess that the name in isl_id is only used
for debugging purposes, as the ISL manual states that "Identifiers
with the same name but different pointer values are considered to
be distinct."
>> @@ -1060,6 +1065,9 @@ openscop_print_pbb_domain (FILE *file, poly_bb_p
>> pbb, int verbosity)
>> graphite_dim_t i;
>> gimple_bb_p gbb = PBB_BLACK_BOX (pbb);
>>
>> + if (isl_set_plain_is_empty (pbb->domain))
>> + return;
>
> Why do we return if a domain is empty. There may be cases where the domain
This change is in untested "feature" (read "bug") code: there are no
testcase, and the code of openscop is not enabled in trunk. I will
remove the code for openscop and let somebody else do the ISL
port for it and re-enable if needed.
Sebastian
