Bernd Edlinger <bernd.edlin...@hotmail.de> writes: > this patch skips the redundant re-computing of the frame info after reload > completed. > > I looked at all available targets initial_elimination_offset functions: > > All of them currently use either a trivial function of > crtl->outgoing_args_size, > get_frame_size () > and df_regs_ever_live_p (x), that can be expected to be evaluated quickly and > to be > constant, > or they use a cached value, if they are called when reload_completed is true. >
Hi Bernd, For the sake of consistency with other targets then this looks fine. I'd both prefer the MIPS backend to be as efficient as other targets and not crash when something like initial elimination offset gets used post reload. Whether it is right or wrong that we end up with these calls post-reload is a different matter but I don't understand the detail enough to comment. > I believe this patch will both be a performance optimization and > guarantee that the frame info can not unexpectedly change when it > should not. I am a bit dubious about this comment as simply not re-computing the frame info is not quite the same as it being consistent with register usage etc. However, we have no check for this right now post-reload so there is no requirement to improve the situation. > I have successfully built a cross-compiler with this patch. > Is it OK for trunk? Has the patch been tested beyond just building GCC? I can do a test run for you if you don't have things set up to do one yourself. Thanks, Matthew
